linux-kernel - Re: [PATCH v2 net-next 14/15] net: dsa: sja1105: implement VLAN retagging for dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aef0d6a9-5edc-a0b1-f6ee-8f82d86b7c60@gmail.com>
Date:   Mon, 11 May 2020 20:41:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, andrew@...n.ch,
        vivien.didelot@...il.com
Cc:     davem@...emloft.net, kuba@...nel.org, jiri@...lanox.com,
        idosch@...sch.org, rmk+kernel@...linux.org.uk,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next 14/15] net: dsa: sja1105: implement VLAN
 retagging for dsa_8021q sub-VLANs



On 5/11/2020 6:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Expand the delta commit procedure for VLANs with additional logic for
> treating bridge_vlans in the newly introduced operating mode,
> SJA1105_VLAN_BEST_EFFORT.
> 
> For every bridge VLAN on every user port, a sub-VLAN index is calculated
> and retagging rules are installed towards a dsa_8021q rx_vid that
> encodes that sub-VLAN index. This way, the tagger can identify the
> original VLANs.
> 
> Extra care is taken for VLANs to still work as intended in cross-chip
> scenarios. Retagging may have unintended consequences for these because
> a sub-VLAN encoding that works for the CPU does not make any sense for a
> front-panel port.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian