| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 May 2020 17:00:49 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: kuba@...nel.org
Cc: joe@...ches.com, netdev@...r.kernel.org, andrew@...n.ch,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] checkpatch: warn about uses of ENOTSUPP
From: Jakub Kicinski <kuba@...nel.org>
Date: Mon, 11 May 2020 10:08:07 -0700
> ENOTSUPP often feels like the right error code to use, but it's
> in fact not a standard Unix error. E.g.:
>
> $ python
>>>> import errno
>>>> errno.errorcode[errno.ENOTSUPP]
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> AttributeError: module 'errno' has no attribute 'ENOTSUPP'
>
> There were numerous commits converting the uses back to EOPNOTSUPP
> but in some cases we are stuck with the high error code for backward
> compatibility reasons.
>
> Let's try prevent more ENOTSUPPs from getting into the kernel.
>
> Recent example:
> https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/
>
> v3 (Joe):
> - fix the "not file" condition.
>
> v2 (Joe):
> - add a link to recent discussion,
> - don't match when scanning files, not patches to avoid sudden
> influx of conversion patches.
> https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/
>
> v1:
> https://lore.kernel.org/netdev/20200510185148.2230767-1-kuba@kernel.org/
>
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Acked-by: Joe Perches <joe@...ches.com>
Applied, thanks Jakub.
Powered by blists - more mailing lists