linux-kernel - Re: [PATCH v4 04/10] mtd: rawnand: stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49c51a13-96a1-0241-f4d1-c5ff7d52921d@st.com>
Date:   Tue, 12 May 2020 08:49:54 +0200
From:   Christophe Kerello <christophe.kerello@...com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <richard@....at>, <vigneshr@...com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <gregkh@...uxfoundation.org>,
        <boris.brezillon@...labora.com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <devicetree@...r.kernel.org>, <marex@...x.de>
Subject: Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup

Hi Miquel,

On 5/11/20 10:39 PM, Miquel Raynal wrote:
> 
> Christophe Kerello <christophe.kerello@...com> wrote on Wed, 6 May 2020
> 11:11:13 +0200:
> 
>> This patch renames functions and local variables.
>> This cleanup is done to get all functions starting by stm32_fmc2_nfc
>> in the FMC2 raw NAND driver when all functions will start by
>> stm32_fmc2_ebi in the FMC2 EBI driver.
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@...com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
> 
> Applied to nand/next as well but for an unknown reason I had to do it
> by hand because the patch would not apply.
> 
> Thanks,
> Miquèl
> 
This is strange, I can apply this patch on my tree without any conflicts.
There is a compilation issue line 1301.

@@ -1302,44 +1298,45 @@ static void stm32_fmc2_write_data(struct 
nand_chip *chip, const void *buf,

  	if (force_8bit && chip->options & NAND_BUSWIDTH_16)
  		/* Reconfigure bus width to 16-bit */
-		stm32_fmc2_set_buswidth_16(fmc2, true);
+		stm32_fmc2_nfc_set_buswidth_16(nfc, true);
  }

I will rebase on top of nand/next today to check that there is no issues 
with the driver.

Regards,
Christophe Kerello.