linux-kernel - Re: [PATCH] ARM: oxnas: make ox820_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <799e6df7-7698-f2a7-e8eb-fd491c1cad8f@baylibre.com>
Date:   Tue, 12 May 2020 10:24:13 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Ma Feng <mafeng.ma@...wei.com>, linux@...linux.org.uk
Cc:     linux-arm-kernel@...ts.infradead.org, linux-oxnas@...ups.io,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: oxnas: make ox820_boot_secondary static

On 12/05/2020 03:46, Ma Feng wrote:
> Fix sparse warning:
> 
> arch/arm/mach-oxnas/platsmp.c:30:12: warning: symbol 'ox820_boot_secondary' was
> not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ma Feng <mafeng.ma@...wei.com>
> ---
>  arch/arm/mach-oxnas/platsmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c
> index ab35275..f0a50b9 100644
> --- a/arch/arm/mach-oxnas/platsmp.c
> +++ b/arch/arm/mach-oxnas/platsmp.c
> @@ -27,7 +27,8 @@ static void __iomem *gic_cpu_ctrl;
>  #define GIC_CPU_CTRL			0x00
>  #define GIC_CPU_CTRL_ENABLE		1
> 
> -int __init ox820_boot_secondary(unsigned int cpu, struct task_struct *idle)
> +static int __init ox820_boot_secondary(unsigned int cpu,
> +		struct task_struct *idle)
>  {
>  	/*
>  	 * Write the address of secondary startup into the
> --
> 2.7.4
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>