linux-kernel - Re: [PATCH] scsi: hisi_sas: display correct proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66c3318d-e8fa-9ff4-c7f4-ebe23925b807@huawei.com>
Date:   Tue, 12 May 2020 09:23:51 +0100
From:   John Garry <john.garry@...wei.com>
To:     Jason Yan <yanaijie@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs

On 12/05/2020 07:33, Jason Yan wrote:
> The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase it is
> not initialized in scsi_host_template. It looks like:
> 
> [root@...alhost ~]# cat /sys/class/scsi_host/host2/proc_name
> (null)
> 

hmmm.. it would be good to tell us what this buys us, apart from the 
proc_name file.

I mean, if we had the sht show_info method implemented, then it could be 
useful (which is even marked as obsolete now).

Thanks,
John

> While the other driver's entry looks like:
> 
> linux-vnMQMU:~ # cat /sys/class/scsi_host/host0/proc_name
> megaraid_sas
> 
> Cc: John Garry <john.garry@...wei.com>
> Cc: Xiang Chen <chenxiang66@...ilicon.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 +
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index fa25766502a2..c205bff20943 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -1757,6 +1757,7 @@ static struct device_attribute *host_attrs_v1_hw[] = {
>   
>   static struct scsi_host_template sht_v1_hw = {
>   	.name			= DRV_NAME,
> +	.proc_name		= DRV_NAME,
>   	.module			= THIS_MODULE,
>   	.queuecommand		= sas_queuecommand,
>   	.target_alloc		= sas_target_alloc,
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index e05faf315dcd..c725cffe141e 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -3533,6 +3533,7 @@ static struct device_attribute *host_attrs_v2_hw[] = {
>   
>   static struct scsi_host_template sht_v2_hw = {
>   	.name			= DRV_NAME,
> +	.proc_name		= DRV_NAME,
>   	.module			= THIS_MODULE,
>   	.queuecommand		= sas_queuecommand,
>   	.target_alloc		= sas_target_alloc,
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> index 374885aa8d77..59b1421607dd 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> @@ -3071,6 +3071,7 @@ static int debugfs_set_bist_v3_hw(struct hisi_hba *hisi_hba, bool enable)
>   
>   static struct scsi_host_template sht_v3_hw = {
>   	.name			= DRV_NAME,
> +	.proc_name		= DRV_NAME,
>   	.module			= THIS_MODULE,
>   	.queuecommand		= sas_queuecommand,
>   	.target_alloc		= sas_target_alloc,
>