linux-kernel - Re: [v2 3/4] regulator: qcom: Add labibb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 May 2020 12:44:52 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Sumit Semwal <sumit.semwal@...aro.org>, agross@...nel.org,
        lgirdwood@...il.com, robh+dt@...nel.org,
        nishakumari@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        kgunda@...eaurora.org, rnayak@...eaurora.org
Subject: Re: [v2 3/4] regulator: qcom: Add labibb driver

On Mon, May 11, 2020 at 07:15:09PM -0700, Bjorn Andersson wrote:
> On Fri 08 May 13:41 PDT 2020, Sumit Semwal wrote:

> > +	int ret;
> > +	struct labibb_regulator *reg = rdev_get_drvdata(rdev);
> > +
> > +	while (retries--) {

> Mark's suggestion of extending _regulator_enable_delay() to support
> polling is_enable() seems reasonable.

> The only complication I can see is that code path currently doesn't have
> any expectations of the regulator not being operational at the end -
> this seems to offer that possibility. So some care needs to be taken
> there.

Are we expecting that to happen in normal operation?  Generally this is
a pretty serious problem.  In any caser if we're adding checks of status
we'd need an error return if the status doesn't show the regulator is on
after some reasonable time.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)