linux-kernel - Re: [PATCH v3] memory/samsung: reduce protected code area in IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99adbca2-7f8f-b255-8538-8819f83d1991@arm.com>
Date:   Tue, 12 May 2020 13:52:58 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Bernard Zhao <bernard@...o.com>, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v3] memory/samsung: reduce protected code area in IRQ



On 5/12/20 1:31 PM, Bernard Zhao wrote:
> This change will speed-up a bit this IRQ processing and there
> is no need to protect return value or printing.
> 
> Signed-off-by: Bernard Zhao <bernard@...o.com>

LGTM

Acked-by: Lukasz Luba <lukasz.luba@....com>


> ---
> Changes since v1:
> *change release lock before the if statement.
> *revert dmc->df->lock mutex lock to protect function
> exynos5_dmc_perf_events_check
> 
> Changes since v2:
> *Improve subject and commit message
> 
> Link for V1:
> *https://lore.kernel.org/patchwork/patch/1238888/
> ---
>   drivers/memory/samsung/exynos5422-dmc.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 22a43d662833..25196d6268e2 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -1346,15 +1346,13 @@ static irqreturn_t dmc_irq_thread(int irq, void *priv)
>   	struct exynos5_dmc *dmc = priv;
>   
>   	mutex_lock(&dmc->df->lock);
> -
>   	exynos5_dmc_perf_events_check(dmc);
> -
>   	res = update_devfreq(dmc->df);
> +	mutex_unlock(&dmc->df->lock);
> +
>   	if (res)
>   		dev_warn(dmc->dev, "devfreq failed with %d\n", res);
>   
> -	mutex_unlock(&dmc->df->lock);
> -
>   	return IRQ_HANDLED;
>   }
>   
>