linux-kernel - Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200512132737.GH28888@kernel.org>
Date:   Tue, 12 May 2020 10:27:37 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Sandipan Das <sandipan@...ux.ibm.com>
Cc:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>, leo.yan@...aro.org,
        jolsa@...nel.org, naveen.n.rao@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file

Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
> 
> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > removed powerpc specific sym-handling.c file from Build. This wasn't
> > caught by build CI because all functions in this file are declared
> > as __weak in common code. Fix it.
> > 
> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > Reported-by: Sandipan Das <sandipan@...ux.ibm.com>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
> > ---
> >  tools/perf/arch/powerpc/util/Build | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> > index e5c9504f8586..e86e210bf514 100644
> > --- a/tools/perf/arch/powerpc/util/Build
> > +++ b/tools/perf/arch/powerpc/util/Build
> > @@ -2,6 +2,7 @@ perf-y += header.o
> >  perf-y += kvm-stat.o
> >  perf-y += perf_regs.o
> >  perf-y += mem-events.o
> > +perf-y += sym-handling.o
> >  
> >  perf-$(CONFIG_DWARF) += dwarf-regs.o
> >  perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> > 
> 
> Thanks for fixing this!
> 
> Acked-by: Sandipan Das <sandipan@...ux.ibm.com>

Leo, Naveen, can you comment on this?

- Arnaldo