linux-kernel - Re: [for-linus][PATCH 3/3] bootconfig: Fix to prevent warning message if no bootconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200512104114.5f70803a@gandalf.local.home>
Date:   Tue, 12 May 2020 10:41:14 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [for-linus][PATCH 3/3] bootconfig: Fix to prevent warning
 message if no bootconfig option

On Tue, 12 May 2020 16:36:53 +0200
Paul Menzel <pmenzel@...gen.mpg.de> wrote:

> Dear Steven,
> 
> 
> Am 12.05.20 um 15:23 schrieb Steven Rostedt:
> > From: Masami Hiramatsu <mhiramat@...nel.org>
> > 
> > Commit de462e5f1071 ("bootconfig: Fix to remove bootconfig
> > data from initrd while boot") causes a cosmetic regression
> > on dmesg, which warns "no bootconfig data" message without
> > bootconfig cmdline option.
> > 
> > Fix setup_boot_config() by moving no bootconfig check after
> > commandline option check.
> > 
> > Link: http://lkml.kernel.org/r/9b1ba335-071d-c983-89a4-2677b522dcc8@molgen.mpg.de
> > Link: http://lkml.kernel.org/r/158916116468.21787.14558782332170588206.stgit@devnote2  
> 
> It’d be great if you could update your script to include HTTPS URLs. 
> That would save one redirect.

Never thought of that as an issue, but sure, it's easy enough to fix.

> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Thanks,

-- Steve