linux-kernel - Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for VSC8541 ethernet-phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 21:12:04 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sagar Shrikant Kadam <sagar.kadam@...ive.com>
Cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        palmer@...belt.com, paul.walmsley@...ive.com, atish.patra@....com,
        devicetree@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for
 VSC8541 ethernet-phy

On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote:
> Adding a OUI (Organizationally Unique Identifier) for VSC8541-01
> device to dt node requires a corresponding dt-binding entry as well
> so that checkpatch doesn't complain with a warning:
> 
> DT compatible string "ethernet-phy-id0007.0771" appears un-documented
> 
> Here extend the existing dt binding of VSC8531 device to include
> VSC8541 device example.

Checkpatch.pl is just dumb here and can be ignored. We have the regex 
that documents this compatible. We don't need every VID/PID listed.

> 
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@...ive.com>
> ---
>  Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 5ff37c6..774448a 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -68,3 +68,6 @@ Example:
>                  vsc8531,led-0-mode	= <LINK_1000_ACTIVITY>;
>                  vsc8531,led-1-mode	= <LINK_100_ACTIVITY>;
>          };
> +        vsc8541_0: ethernet-phy@0 {
> +                compatible = "ethernet-phy-id0007.0771";
> +	};
> -- 
> 2.7.4
>