linux-kernel - Re: [v1,1/1] hwmon: (nct7904) Fix the incorrect rang of temperature limitation registers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200513152120.GA125233@roeck-us.net>
Date:   Wed, 13 May 2020 08:21:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Amy.Shih@...antech.com.tw
Cc:     she90122@...il.com, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        oakley.ding@...antech.com.tw, jia.sui@...antech.com.cn,
        yuechao.zhao@...antech.com.cn, Hy.Lee@...antech.com.tw
Subject: Re: [v1,1/1] hwmon: (nct7904) Fix the incorrect rang of temperature
 limitation registers.

On Tue, May 12, 2020 at 09:38:06AM +0000, Amy.Shih@...antech.com.tw wrote:
> From: Amy Shih <amy.shih@...antech.com.tw>
> 
> The format of temperature limitation registers are 8-bit 2's complement
> and the range is -128~127.
> Converts the reading value to signed char to fix the incorrect range
> of temperature limitation registers.
> 
> Signed-off-by: Amy Shih <amy.shih@...antech.com.tw>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct7904.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 6fb06f7..04f2a8e 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -390,6 +390,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
>  	struct nct7904_data *data = dev_get_drvdata(dev);
>  	int ret, temp;
>  	unsigned int reg1, reg2, reg3;
> +	s8 temps;
>  
>  	switch (attr) {
>  	case hwmon_temp_input:
> @@ -495,7 +496,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
>  
>  	if (ret < 0)
>  		return ret;
> -	*val = ret * 1000;
> +	temps = ret;
> +	*val = temps * 1000;
>  	return 0;
>  }
>  
> -- 
> 1.8.3.1
>