linux-kernel - [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 May 2020 17:47:18 +0200
From:   michael.srba@...nam.cz
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Michael Srba <michael.srba@...nam.cz>
Subject: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

From: Michael Srba <michael.srba@...nam.cz>

Attempting to enable these devices causes a "synchronous
external abort". Suspected cause is that the debug power
domain is not enabled by default on this device.
Disable these devices for now to avoid the crash.

See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@gerhold.net/

Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
Signed-off-by: Michael Srba <michael.srba@...nam.cz>

---
 arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts       | 6 ++++++
 arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
index d1ccb9472c8b..28983b871a70 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
@@ -105,6 +105,12 @@ wcnss@...b000 {
 		etm@...000 { status = "disabled"; };
 		etm@...000 { status = "disabled"; };
 		etm@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
 	};
 
 	// FIXME: Use extcon device provided by charger driver when available
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
index 43c5e0f882f1..8569a1532a3f 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
@@ -98,6 +98,12 @@ wcnss@...b000 {
 		etm@...000 { status = "disabled"; };
 		etm@...000 { status = "disabled"; };
 		etm@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
+		cti@...000 { status = "disabled"; };
 	};
 
 	gpio-keys {
-- 
2.24.0