linux-kernel - RE: gcc-10: kernel stack is corrupted and fails to boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88aae01f75584c2ea8df3f59a43dcddd@AcuMS.aculab.com>
Date:   Wed, 13 May 2020 16:07:57 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Arnd Bergmann' <arnd@...db.de>, Kalle Valo <kvalo@...eaurora.org>
CC:     linux-wireless <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: gcc-10: kernel stack is corrupted and fails to boot

From: Arnd Bergmann
> Sent: 13 May 2020 17:00
> On Wed, May 13, 2020 at 5:31 PM Kalle Valo <kvalo@...eaurora.org> wrote:
...
> I investigated a little more: This does happen with 'defconfig'
> after all, in my first try I must have missed the '-smp 2' argument
> to qemu, and it ended up working correctly with just one CPU
> but fails now.
> 
> Stepping through the boot process, I see where it crashes
> in start_secondary:
> 
> |        /* to prevent fake stack check failure in clock setup */
> |        boot_init_stack_canary();
> |
> |        x86_cpuinit.setup_percpu_clockev();
> |
> |        wmb();
> |        cpu_startup_entry(CPUHP_AP_ONLINE_IDLE);
> 
> The call to cpu_startup_entry() does not succeed, instead
> it jumps to __stack_chk_fail() from there.

Hasn't this already been fixed?
Add:
		asm("");
after cpu_startup_entry() to stop it being tail-called.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)