linux-kernel - Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af456130-e54c-28ff-b71e-f2da43331a8f@seznam.cz>
Date:   Wed, 13 May 2020 18:42:48 +0200
From:   Michael Srba <Michael.Srba@...nam.cz>
To:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices
 with broken coresight

On 13. 05. 20 18:04, Jeffrey Hugo wrote:
> On Wed, May 13, 2020 at 9:53 AM <michael.srba@...nam.cz> wrote:
>> From: Michael Srba <michael.srba@...nam.cz>
>>
>> Attempting to enable these devices causes a "synchronous
>> external abort". Suspected cause is that the debug power
>> domain is not enabled by default on this device.
>> Disable these devices for now to avoid the crash.
>>
>> See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@gerhold.net/
>>
>> Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
>> Signed-off-by: Michael Srba <michael.srba@...nam.cz>
>>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts       | 6 ++++++
>>  arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
>>  2 files changed, 12 insertions(+)
> Why are we disabling these in board specific files?  Seems like these
> should be disabled in the base msm8916.dtsi.  Otherwise, the next
> board that gets brought up is probably going to hit this same exact
> issue.
>
> This also follows the solution that msm8998 did for the same issue.

I would also advocate for having them disabled by default. I *think* it was
brought up initially, but that would be before the msm8998 change.