linux-kernel - Re: [PATCH] hwmon: da9052: Synchronize access with mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200513170744.GA133638@roeck-us.net>
Date:   Wed, 13 May 2020 10:07:44 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Jean Delvare <jdelvare@...e.com>,
        Lee Jones <lee.jones@...aro.org>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Samu Nuutamo <samu.nuutamo@...cit.fi>
Subject: Re: [PATCH] hwmon: da9052: Synchronize access with mfd

On Mon, May 11, 2020 at 01:02:19PM +0200, Sebastian Reichel wrote:
> From: Samu Nuutamo <samu.nuutamo@...cit.fi>
> 
> When tsi-as-adc is configured it is possible for in7[0123]_input read to
> return an incorrect value if a concurrent read to in[456]_input is
> performed. This is caused by a concurrent manipulation of the mux
> channel without proper locking as hwmon and mfd use different locks for
> synchronization.
> 
> Switch hwmon to use the same lock as mfd when accessing the TSI channel.
> 
> Fixes: 4f16cab19a3d5 ("hwmon: da9052: Add support for TSI channel")
> Signed-off-by: Samu Nuutamo <samu.nuutamo@...cit.fi>
> [rebase to current master, reword commit message slightly]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Applied.

Thanks,
Guenter