linux-kernel - Re: [PATCH] greybus: audio: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200513174530.GA32096@animalcreek.com>
Date:   Wed, 13 May 2020 10:45:30 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Mark Greer <mgreer@...malcreek.com>,
        linux-kernel@...r.kernel.org, greybus-dev@...ts.linaro.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] greybus: audio: remove unused code

On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> reported in September 2016, it depends on an "out-of-tree qualcomm audio
> driver". This driver never made it upstream.
> 
> https://lore.kernel.org/lkml/20160921073905.GA31263@kroah.com/
> 
> Moreover, there doesn't seem to be any interest in actually fixing the
> driver as it uses ASoC APIs that have been removed from the kernel in 2018
> as shown by its use of snd_soc_register_codec and
> snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> Codec related code").
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---

Everything you say is true but it is still kinda sad to see this go.
But that is life...  If and when someone has the motivation to get this
working again they can take a look at the git history.

Thanks for this, Alexandre.

Acked-by: Mark Greer <mgreer@...malcreek.com>