linux-kernel - Re: [PATCH] wfx: typo fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3242246.g26XRxWjXc@pc-42>
Date:   Wed, 13 May 2020 20:02:34 +0200
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     Mohamed Dawod <mhm.dawod@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wfx: typo fix

Hello,

On Wednesday 13 May 2020 09:24:33 CEST Mohamed Dawod wrote:
> 
> fixing some typo errors in traces.h file
> 
> Signed-off-by: Mohamed Dawod <mhm.dawod@...il.com>
> ---
>  drivers/staging/wfx/traces.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

It would be great if the subject started with "staging: wfx: " (as
the other patches of this directory).

Else, I like when commit messages start with a capital letter, but it is not big
deal.


> diff --git a/drivers/staging/wfx/traces.h b/drivers/staging/wfx/traces.h
> index bb9f7e9..80e131c 100644
> --- a/drivers/staging/wfx/traces.h
> +++ b/drivers/staging/wfx/traces.h
> @@ -32,16 +32,16 @@
>   *             xxx_name(XXX)       \
>   *             ...
>   *
> - *   3. Instanciate that list_names:
> + *   3. Instantiate that list_names:
>   *
>   *          list_names
>   *
> - *   4. Redefine xxx_name() as a entry of array for __print_symbolic()
> + *   4. Redefine xxx_name() as an entry of array for __print_symbolic()
>   *
>   *          #undef xxx_name
>   *          #define xxx_name(msg) { msg, #msg },
>   *
> - *   5. list_name can now nearlu be used with __print_symbolic() but,
> + *   5. list_name can now nearly be used with __print_symbolic() but,
>   *      __print_symbolic() dislike last comma of list. So we define a new list
>   *      with a dummy element:

Ok.


Thank you for your contribution.

-- 
Jérôme Pouiller