linux-kernel - Re: [PATCH] dt-bindings: at24: add microchip,24lc[0-9]+ to the compatible pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 May 2020 03:33:39 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] dt-bindings: at24: add microchip,24lc[0-9]+ to the
 compatible pattern

Hi Rob,


On Tue, May 12, 2020 at 4:14 AM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, 22 Apr 2020 23:18:36 +0900, Masahiro Yamada wrote:
> > arch/arm/boot/dts/uniphier-ref-daughter.dtsi has
> >
> >   compatible = "microchip,24lc128", "atmel,24c128";
> >
> > and 'make ARCH=arm dtbs_check' warns this:
> >
> >   eeprom@50: compatible: ['microchip,24lc128', 'atmel,24c128'] is not valid under any of the given schemas (Possible causes of the failure)
> >
> > Microchip 24LC128 is the device used on this board, and I see it in
> > https://www.microchip.com/wwwproducts/en/24LC128
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > ---
> >
> >  Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Applied, thanks!


If it is not too late, can you correct the patch subject?



See the applied commit in linux-next.



Author: Masahiro Yamada <yamada.masahiro@...ionext.com>
Date:   Wed Apr 22 23:18:36 2020 +0900

    dt-bindings: at24: add microchip, 24lc[0-9]+ to the compatible pattern




Please notice a space after 'microchip,'



And this is the patch I submitted:

https://lore.kernel.org/patchwork/patch/1229480/


No space after 'microchip,'




This is a patchwork bug.
It automatically inserts a space after a comma.
Patchwork adds various unpleasant modification,
and breaks the commit subject and log.

I reported this bug to patchwork ML, but
still not fixed...



-- 
Best Regards
Masahiro Yamada