linux-kernel - RE: [PATCH v2 00/10] x86/resctrl: Misc cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83fcdce7-1ecb-7314-ed03-05ae25d90259@amd.com>
Date:   Wed, 13 May 2020 15:03:08 -0500
From:   Babu Moger <babu.moger@....com>
To:     James Morse <james.morse@....com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        H Peter Anvin <hpa@...or.com>
Subject: RE: [PATCH v2 00/10] x86/resctrl: Misc cleanup

Hi James,
Patches all look good. Tested on AMD platform and working as expected.

Reviewed-by: Babu Moger <babu.moger@....com>

Thanks

> -----Original Message-----
> From: James Morse <james.morse@....com>
> Sent: Thursday, April 30, 2020 12:04 PM
> To: x86@...nel.org; linux-kernel@...r.kernel.org
> Cc: Fenghua Yu <fenghua.yu@...el.com>; Reinette Chatre
> <reinette.chatre@...el.com>; Thomas Gleixner <tglx@...utronix.de>; Ingo
> Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>; H Peter Anvin
> <hpa@...or.com>; Moger, Babu <Babu.Moger@....com>; James Morse
> <james.morse@....com>
> Subject: [PATCH v2 00/10] x86/resctrl: Misc cleanup
> 
> Hello!
> 
> These are the miscellaneous cleanup patches that floated to the top of
> the MPAM tree.
> 
> The only interesting thing are the patches to make the AMD/Intel
> differences something resctrl understands, instead of just 'happening'
> because of the different function pointers.
> This will become more important once MPAM support is added. parse_bw()
> and friends are what enforces resctrl's ABI resctrl. Allowing an
> architecture/platform to provide a subtly different function here would
> be bad for user-space.
> 
> MPAM would set arch_has_sparse_bitmaps, but not arch_needs_linear.
> 
> Since [v1], I've picked up all the review feedback and collected the
> tags.
> 
> Nothing in this series should change any behaviour.
> This series is based on v5.7-rc3.
> 
> Thanks,
> 
> James
> 
> [v1]
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
> nel.org%2Flkml%2F20200214182401.39008-1-
> james.morse%40arm.com%2F&amp;data=02%7C01%7CBabu.Moger%40amd.c
> om%7C1d3c1ee27e204ebece3808d7ed288034%7C3dd8961fe4884e608e11a82d
> 994e183d%7C0%7C0%7C637238630922264101&amp;sdata=Gcfop8YPzsPFq8fk
> bgnR%2FZgQApnQYVbaCdRlhpE2YPE%3D&amp;reserved=0
> 
> James Morse (10):
>   x86/resctrl: Nothing uses struct mbm_state chunks_bw
>   x86/resctrl: Remove max_delay
>   x86/resctrl: Fix stale comment
>   x86/resctrl: use container_of() in delayed_work handlers
>   x86/resctrl: Include pid.h
>   x86/resctrl: Use is_closid_match() in more places
>   x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference
>   x86/resctrl: Merge AMD/Intel parse_bw() calls
>   x86/resctrl: Add arch_has_sparse_bitmaps to explain AMD/Intel CAT
>     difference
>   cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file
> 
>  arch/x86/kernel/cpu/resctrl/core.c        | 35 +++------
>  arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 89 +++--------------------
>  arch/x86/kernel/cpu/resctrl/internal.h    | 19 ++---
>  arch/x86/kernel/cpu/resctrl/monitor.c     | 15 +---
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 32 ++++----
>  include/linux/cacheinfo.h                 | 21 ++++++
>  include/linux/resctrl.h                   |  2 +
>  7 files changed, 70 insertions(+), 143 deletions(-)
> 
> --
> 2.26.1