linux-kernel - Re: [PATCH v2] kernel: sysctl: ignore out-of-range taint bits introduced via kernel.tainted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200513003953.GK11244@42.do-not-panic.com>
Date:   Wed, 13 May 2020 00:39:53 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Rafael Aquini <aquini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        keescook@...omium.org, akpm@...ux-foundation.org,
        yzaikin@...gle.com, tytso@....edu
Subject: Re: [PATCH v2] kernel: sysctl: ignore out-of-range taint bits
 introduced via kernel.tainted

On Tue, May 12, 2020 at 06:39:46PM -0400, Rafael Aquini wrote:
> Users with SYS_ADMIN capability can add arbitrary taint flags
> to the running kernel by writing to /proc/sys/kernel/tainted
> or issuing the command 'sysctl -w kernel.tainted=...'.
> These interface, however, are open for any integer value
> and this might an invalid set of flags being committed to
> the tainted_mask bitset.
> 
> This patch introduces a simple way for proc_taint() to ignore
> any eventual invalid bit coming from the user input before
> committing those bits to the kernel tainted_mask.
> 
> Signed-off-by: Rafael Aquini <aquini@...hat.com>

Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis