[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdWoh94eFvVKHt5si3LOX4Nwx0-JssxVOy=fXPMXxgndXg@mail.gmail.com>
Date: Wed, 13 May 2020 09:04:28 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robh@...nel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
linux-clk <linux-clk@...r.kernel.org>,
USB list <linux-usb@...r.kernel.org>,
linux-spi <linux-spi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 5/5] dt-bindings: Fix incorrect 'reg' property sizes
Hi Rob,
On Tue, May 12, 2020 at 10:46 PM Rob Herring <robh@...nel.org> wrote:
> The examples template is a 'simple-bus' with a size of 1 cell for
> #address-cells and #size-cells. The schema was only checking the entries
> had between 2 and 4 cells which really only errors on I2C or SPI type
> devices with a single cell.
>
> The easiest fix in most cases is to change the 'reg' property to for 1 cell
> address and size. In some cases with child devices having 2 cells, that
> doesn't make sense so a bus node is needed.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
Thanks for your patch!
> .../devicetree/bindings/arm/renesas,prr.yaml | 2 +-
> .../bindings/display/renesas,cmm.yaml | 2 +-
> .../interrupt-controller/renesas,irqc.yaml | 2 +-
> .../bindings/media/renesas,csi2.yaml | 2 +-
> .../bindings/media/renesas,vin.yaml | 6 +-
> .../bindings/net/renesas,ether.yaml | 2 +-
> .../bindings/pwm/renesas,pwm-rcar.yaml | 2 +-
> .../bindings/spi/renesas,sh-msiof.yaml | 2 +-
> .../bindings/thermal/rcar-thermal.yaml | 6 +-
> .../bindings/usb/renesas,usb3-peri.yaml | 2 +-
> .../bindings/usb/renesas,usbhs.yaml | 2 +-
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists