linux-kernel - Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANh8QzxJg05nXasHfN2kC-G7TOKZ8trJkOP_v0KXvcy6S4df4Q@mail.gmail.com>
Date:   Wed, 13 May 2020 09:12:13 +0200
From:   "Fuzzey, Martin" <martin.fuzzey@...wbird.group>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     Robin Gong <yibin.gong@....com>, vkoul@...nel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Rob Herring <robh+dt@...nel.org>,
        Fabio Estevam <festevam@...il.com>, dan.j.williams@...el.com,
        mark.rutland@....com, catalin.marinas@....com,
        Will Deacon <will.deacon@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

On Wed, 13 May 2020 at 08:07, Sascha Hauer <s.hauer@...gutronix.de> wrote:
>
> On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote:
> > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since
> > 'context_loaded' finally removed.
> >
> > Signed-off-by: Robin Gong <yibin.gong@....com>
> > ---
>
> I think this can safely be folded into the next patch which makes it
> more clear what is happening.
>

Agreed,
not only that but having 2 separate patches also means that the bug
that was fixed by the commit being reverted could reappear during
bisection.

More generally I think reverts should be reserved for commits that
later turn out to be wrong or unneeded (ie should never really have
been applied).
If they were OK at the time but later become unnecessary due to other
code changes I think all the related modifications should be done in a
single normal non revert patch.

Martin