linux-kernel - RE: [PATCH v1 1/1] tty: serial: add missing spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR13MB261414A78707F1020FC529B599BF0@BYAPR13MB2614.namprd13.prod.outlook.com>
Date:   Wed, 13 May 2020 08:14:47 +0000
From:   Sagar Kadam <sagar.kadam@...ive.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Palmer Dabbelt <palmer@...belt.com>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        Atish Patra <Atish.Patra@....com>,
        Anup Patel <Anup.Patel@....com>
Subject: RE: [PATCH v1 1/1] tty: serial: add missing spin_lock_init for SiFive
 serial console

Hello Greg and Palmer,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Wednesday, May 13, 2020 12:30 PM
> To: Palmer Dabbelt <palmer@...belt.com>
> Cc: Sagar Kadam <sagar.kadam@...ive.com>; linux-serial@...r.kernel.org;
> linux-riscv@...ts.infradead.org; linux-kernel@...r.kernel.org; Paul Walmsley
> <paul.walmsley@...ive.com>; aou@...s.berkeley.edu; Atish Patra
> <Atish.Patra@....com>; Anup Patel <Anup.Patel@....com>
> Subject: Re: [PATCH v1 1/1] tty: serial: add missing spin_lock_init for SiFive
> serial console
> 
> [External Email] Do not click links or attachments unless you recognize the
> sender and know the content is safe
> 
> On Tue, May 12, 2020 at 04:00:23PM -0700, Palmer Dabbelt wrote:
> > On Sat, 09 May 2020 03:24:12 PDT (-0700), sagar.kadam@...ive.com wrote:
> > > An uninitialised spin lock for sifive serial console raises a bad
> > > magic spin_lock error as reported and discussed here [1].
> > > Initialising the spin lock resolves the issue.
> > >
> > > The fix is tested on HiFive Unleashed A00 board with Linux 5.7-rc4
> > > and OpenSBI v0.7
> > >
> > > [1]
> > > https://lore.kernel.org/linux-riscv/b9fe49483a903f404e7acc15a6efbef7
> > > 56db28ae.camel@....com
> > >
> > > Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART")
> > > Reported-by: Atish Patra <Atish.Patra@....com>
> > > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@...ive.com>
> > > ---
> > >  drivers/tty/serial/sifive.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/tty/serial/sifive.c
> > > b/drivers/tty/serial/sifive.c index 13eadcb..0b5110d 100644
> > > --- a/drivers/tty/serial/sifive.c
> > > +++ b/drivers/tty/serial/sifive.c
> > > @@ -883,6 +883,7 @@ console_initcall(sifive_console_init);
> > >
> > >  static void __ssp_add_console_port(struct sifive_serial_port *ssp)
> > > {
> > > +   spin_lock_init(&ssp->port.lock);
> > >     sifive_serial_console_ports[ssp->port.line] = ssp;  }
> >
> > Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> > Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> >

Thanks for the review.

> > I'm assuming it's going in through Greg's tree.
> 
> Sure, I'll be glad to take it.
> 

Thanks for accepting it within your tree.

BR,
Sagar Kadam

> greg k-h