linux-kernel - Re: [PATCH][next] sfc: fix dereference of table before it is null checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <680245f9-e26d-87e1-6e52-138302950e06@solarflare.com>
Date:   Wed, 13 May 2020 10:39:43 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Colin King <colin.king@...onical.com>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Martin Habets <mhabets@...arflare.com>,
        "David S . Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] sfc: fix dereference of table before it is null
 checked

On 12/05/2020 18:13, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue.  Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: Edward Cree <ecree@...arflare.com>