lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2020 11:45:19 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Vince Weaver <vincent.weaver@...ne.edu>, Dave Jones <dsj@...com>, Steven Rostedt <rostedt@...dmis.org>, Vegard Nossum <vegard.nossum@...cle.com>, Joe Mario <jmario@...hat.com>, Miroslav Benes <mbenes@...e.cz>, Josh Poimboeuf <jpoimboe@...hat.com>, Ingo Molnar <mingo@...nel.org>, Andy Lutomirski <luto@...nel.org>, Jann Horn <jannh@...gle.com>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de> Subject: [PATCH 5.4 83/90] objtool: Fix stack offset tracking for indirect CFAs From: Josh Poimboeuf <jpoimboe@...hat.com> commit d8dd25a461e4eec7190cb9d66616aceacc5110ad upstream. When the current frame address (CFA) is stored on the stack (i.e., cfa->base == CFI_SP_INDIRECT), objtool neglects to adjust the stack offset when there are subsequent pushes or pops. This results in bad ORC data at the end of the ENTER_IRQ_STACK macro, when it puts the previous stack pointer on the stack and does a subsequent push. This fixes the following unwinder warning: WARNING: can't dereference registers at 00000000f0a6bdba for ip interrupt_entry+0x9f/0xa0 Fixes: 627fce14809b ("objtool: Add ORC unwind table generation") Reported-by: Vince Weaver <vincent.weaver@...ne.edu> Reported-by: Dave Jones <dsj@...com> Reported-by: Steven Rostedt <rostedt@...dmis.org> Reported-by: Vegard Nossum <vegard.nossum@...cle.com> Reported-by: Joe Mario <jmario@...hat.com> Reviewed-by: Miroslav Benes <mbenes@...e.cz> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com> Signed-off-by: Ingo Molnar <mingo@...nel.org> Cc: Andy Lutomirski <luto@...nel.org> Cc: Jann Horn <jannh@...gle.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Thomas Gleixner <tglx@...utronix.de> Link: https://lore.kernel.org/r/853d5d691b29e250333332f09b8e27410b2d9924.1587808742.git.jpoimboe@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1402,7 +1402,7 @@ static int update_insn_state_regs(struct struct cfi_reg *cfa = &state->cfa; struct stack_op *op = &insn->stack_op; - if (cfa->base != CFI_SP) + if (cfa->base != CFI_SP && cfa->base != CFI_SP_INDIRECT) return 0; /* push */
Powered by blists - more mailing lists