linux-kernel - Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200513105144.GC4803@sirena.org.uk>
Date:   Wed, 13 May 2020 11:51:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Steve Lee <steves.lee.maxim@...il.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        ckeepax@...nsource.cirrus.com, geert@...ux-m68k.org,
        rf@...nsource.wolfsonmicro.com, shumingf@...ltek.com,
        srinivas.kandagatla@...aro.org, krzk@...nel.org, dmurphy@...com,
        jack.yu@...ltek.com, nuno.sa@...log.com,
        steves.lee@...imintegrated.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, ryan.lee.maxim@...il.com,
        ryans.lee@...imintegrated.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:

> Changes since V2:
> 	* Removed warn massage in max98390_dsm_calib_get func 
> 	  and add comment.

The problem isn't the warning, the problem is that you have an empty
operation.  You should either implement the function (eg, by caching the
value written) or remove it and fix whatever problems you were running
into further up the stack when it's missing.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)