linux-kernel - Re: [PATCH] char: ipmi: convert to use i2c_new_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200513111825.GB9928@minyard.net>
Date:   Wed, 13 May 2020 06:18:25 -0500
From:   Corey Minyard <cminyard@...sta.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     minyard@....org, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ipmi: convert to use i2c_new_client_device()

On Wed, May 13, 2020 at 10:37:46AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 04:45:32PM -0500, minyard@....org wrote:
> > From: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > 
> > Move away from the deprecated API.
> > 
> > Based on a patch by Wolfram Sang <wsa+renesas@...g-engineering.com>.
> > 
> > Signed-off-by: Corey Minyard <cminyard@...sta.com>
> > ---
> > I think this works.
> 
> Yes, we can do it like this (despite the question from earlier if it is
> really needed). I fixed other drivers using this pattern, too.

I was wondering whether this is really needed, too, but I'm not 100%
sure it can be removed in all cases.  This is the safer route.

> 
> As Stephen Rothwell pointed out, you either need to remove my "From:" or
> add my SoB. I am fine with both.

It was enough of a rewrite that you as the author didn't seem right.
I've fixed the From line, sorry about that.

-corey

> 
> Thanks,
> 
>    Wolfram
>