linux-kernel - Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200513115600.GB953616@kroah.com>
Date:   Wed, 13 May 2020 13:56:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Matej Dujava <mdujava@...urkovo.cz>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile
 variable definitions

On Sun, May 10, 2020 at 12:13:35PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
> at the begining of the file.

Why change the order?  What does that fix?  Why do this?  You say what
you do here, but not why.  And without that, I can't see the reason to
accept this patch :(

thanks,

greg k-h