linux-kernel - Re: [v1,1/1] watchdog: (nct7904) Fix enable watchdog incorrectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96a8cff0-e21c-cc2c-3358-1e8e6b754c6a@roeck-us.net>
Date:   Wed, 13 May 2020 06:16:13 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     yuechao.zhao@...antech.com.cn, 345351830@...com
Cc:     amy.shih@...antech.com.tw, oakley.ding@...antech.com.tw,
        jia.sui@...antech.com.cn, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1,1/1] watchdog: (nct7904) Fix enable watchdog incorrectly

On 5/13/20 4:00 AM, yuechao.zhao@...antech.com.cn wrote:
> From: Yuechao Zhao <yuechao.zhao@...antech.com.cn>
> 
> Use incorrect register to enable watchdog in nct7904_wdt_ping()
> 

I assume you mean 'correct'.

Guenter

> Signed-off-by: Yuechao Zhao <yuechao.zhao@...antech.com.cn>
> ---
>  drivers/hwmon/nct7904.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 04f2a8e..18c95be 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -979,7 +979,7 @@ static int nct7904_wdt_ping(struct watchdog_device *wdt)
>  		return ret;
>  
>  	/* Enable soft watchdog timer */
> -	return nct7904_write_reg(data, BANK_0, WDT_TIMER_REG, WDT_SOFT_EN);
> +	return nct7904_write_reg(data, BANK_0, WDT_LOCK_REG, WDT_SOFT_EN);
>  }
>  
>  static unsigned int nct7904_wdt_get_timeleft(struct watchdog_device *wdt)
>