linux-kernel - Re: [GIT PULL] thread fixes v5.7-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjpb-h9Z6O6o_7GkqCV1N-qQhagVJxpYZurYQR+eLkuEg@mail.gmail.com>
Date:   Thu, 14 May 2020 11:07:59 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] thread fixes v5.7-rc5

On Thu, May 14, 2020 at 10:05 AM Christian Brauner
<christian.brauner@...ntu.com> wrote:
>
> This contains a single fix for all exported legacy fork helpers to block
> accidental access to clone3() features in the upper 32 bits of their
> respective flags arguments.

I've taken this pull, but I really think the minimal and more
straightforward fix would have been to just make do_fork(),
kernel_thread() and clone() change the flags field from "unsigned
long" to "unsigned int".

I don't see why that wouldn't have fixed things, and it would have
been simpler and more obvious, I think.

Doesn't matter, I guess.

                   Linus