linux-kernel - Re: [PATCH v5 3/5] remoteproc: qcom: Update PIL relocation info on load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 02:48:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/5] remoteproc: qcom: Update PIL relocation info on
 load

Hi Bjorn,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.7-rc5 next-20200514]
[cannot apply to agross-msm/qcom/for-next remoteproc/for-next rpmsg/for-next hwspinlock/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Bjorn-Andersson/remoteproc-qcom-PIL-info-support/20200514-161851
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_load':
>> drivers/remoteproc/qcom_q6v5_wcss.c:433:2: error: implicit declaration of function 'qcom_pil_info_store' [-Werror=implicit-function-declaration]
433 |  qcom_pil_info_store("wcnss", wcss->mem_reloc, wcss->mem_size);
|  ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/qcom_pil_info_store +433 drivers/remoteproc/qcom_q6v5_wcss.c

   420	
   421	static int q6v5_wcss_load(struct rproc *rproc, const struct firmware *fw)
   422	{
   423		struct q6v5_wcss *wcss = rproc->priv;
   424		int ret;
   425	
   426		ret = qcom_mdt_load_no_init(wcss->dev, fw, rproc->firmware,
   427					    0, wcss->mem_region, wcss->mem_phys,
   428					    wcss->mem_size, &wcss->mem_reloc);
   429		if (ret)
   430			return ret;
   431	
   432		/* Failures only affect post mortem debugging, so ignore return value */
 > 433		qcom_pil_info_store("wcnss", wcss->mem_reloc, wcss->mem_size);
   434	
   435		return ret;
   436	}
   437	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71781 bytes)