linux-kernel - RE: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 May 2020 15:41:35 -0500
From:   Babu Moger <babu.moger@....com>
To:     Reinette Chatre <reinette.chatre@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "tony.luck@...el.com" <tony.luck@...el.com>
Cc:     "kuo-lang.tseng@...el.com" <kuo-lang.tseng@...el.com>,
        "ravi.v.shankar@...el.com" <ravi.v.shankar@...el.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA



> -----Original Message-----
> From: Reinette Chatre <reinette.chatre@...el.com>
> Sent: Thursday, May 14, 2020 3:12 PM
> To: Moger, Babu <Babu.Moger@....com>; tglx@...utronix.de;
> fenghua.yu@...el.com; bp@...en8.de; tony.luck@...el.com
> Cc: kuo-lang.tseng@...el.com; ravi.v.shankar@...el.com; mingo@...hat.com;
> hpa@...or.com; x86@...nel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA
> 
> Hi Babu,
> 
> On 5/14/2020 12:04 PM, Babu Moger wrote:
> >
> >
> >> -----Original Message-----
> >> From: Reinette Chatre <reinette.chatre@...el.com>
> >> Sent: Wednesday, May 6, 2020 6:50 PM
> >> To: tglx@...utronix.de; fenghua.yu@...el.com; bp@...en8.de;
> >> tony.luck@...el.com
> >> Cc: kuo-lang.tseng@...el.com; ravi.v.shankar@...el.com;
> mingo@...hat.com;
> >> Moger, Babu <Babu.Moger@....com>; hpa@...or.com; x86@...nel.org;
> >> linux-kernel@...r.kernel.org; Reinette Chatre <reinette.chatre@...el.com>
> >> Subject: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA
> >>
> >> From: Fenghua Yu <fenghua.yu@...el.com>
> >>
> 
> ...
> 
> >> diff --git a/arch/x86/kernel/cpu/scattered.c
> b/arch/x86/kernel/cpu/scattered.c
> >> index 62b137c3c97a..bccfc9ff3cc1 100644
> >> --- a/arch/x86/kernel/cpu/scattered.c
> >> +++ b/arch/x86/kernel/cpu/scattered.c
> >> @@ -35,6 +35,7 @@ static const struct cpuid_bit cpuid_bits[] = {
> >>  	{ X86_FEATURE_CDP_L3,		CPUID_ECX,  2, 0x00000010, 1
> >> },
> >>  	{ X86_FEATURE_CDP_L2,		CPUID_ECX,  2, 0x00000010, 2
> >> },
> >>  	{ X86_FEATURE_MBA,		CPUID_EBX,  3, 0x00000010, 0 },
> >> +	{ X86_FEATURE_PER_THREAD_MBA,	CPUID_ECX,  0, 0x00000010, 3
> >> },
> >
> > This is a CPUID feature. You can actually detect this feature without
> > checking vendor model in patch @1. This patch looks good to me.
> >
> 
> This feature is different from the feature introduced in patch 1.

Ok.  I mis-understood that.