linux-kernel - Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 00:02:59 +0300
From:   Georgi Djakov <georgi.djakov@...aro.org>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Felipe Balbi <balbi@...nel.org>
Cc:     Sandeep Maheswaram <sanm@...eaurora.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Manu Gautam <mgautam@...eaurora.org>,
        Chandana Kishori Chiluveru <cchiluve@...eaurora.org>,
        Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3
 driver

On 5/14/20 20:13, Matthias Kaehlcke wrote:
> On Thu, May 14, 2020 at 02:30:28PM +0300, Felipe Balbi wrote:
>> Felipe Balbi <balbi@...nel.org> writes:
>>
>>> Hi,
>>>
>>> Sandeep Maheswaram <sanm@...eaurora.org> writes:
>>>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
>>>> +{
>>>> +	struct device *dev = qcom->dev;
>>>> +	int ret;
>>>> +
>>>> +	if (!device_is_bound(&qcom->dwc3->dev))
>>>> +		return -EPROBE_DEFER;
>>>
>>> this breaks allmodconfig. I'm dropping this series from my queue for
>>> this merge window.
>>
>> Sorry, I meant this patch ;-)
> 
> I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

> discussion about this  with Viresh and Georgi in response to another
> automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
> from tristate to bool, which seems sensible to me given that interconnect
> is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and
USB_DWC3_QCOM=y and it definitely exists here and could be triggered with
randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

---8<---
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 206caa0ea1c6..6661788b1a76 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT
 	depends on (OF || ACPI)
 	default USB_DWC3
 	help