linux-kernel - Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 May 2020 23:45:04 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Miroslav Benes <mbenes@...e.cz>,
        Petr Mladek <pmladek@...e.com>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        live-patching@...r.kernel.org, Joe Perches <joe@...ches.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal

On Sat, 9 May 2020, Kamalesh Babulal wrote:

> > Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> > arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> > in MAINTAINERS.
> > 
> > Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> > 
> >   warning: no file matches  F:  arch/x86/kernel/livepatch.c
> > 
> > So, drop that obsolete file entry in MAINTAINERS.
> 
> Patch looks good to me,  you probably want to add following architecture
> specific livepatching header files to the list:
> 
> arch/s390/include/asm/livepatch.h
> arch/powerpc/include/asm/livepatch.h

Good point, thanks for spotting it Kamalesh. I've queued the patch below 
on top.



From: Jiri Kosina <jkosina@...e.cz>
Subject: [PATCH] livepatch: add arch-specific headers to MAINTAINERS

Add arch-specific livepatch.h for s390 and powerpc to MAINTAINERS
F: patterns.

Reported-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7e0827670425..8e14444eb98d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9854,6 +9854,8 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
+F:	arch/powerpc/include/asm/livepatch.h
+F:	arch/s390/include/asm/livepatch.h
 F:	arch/x86/include/asm/livepatch.h
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/


-- 
Jiri Kosina
SUSE Labs