lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 May 2020 10:39:43 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Tony Lindgren <tony@...mide.com>, <linux-omap@...r.kernel.org>
CC:     "Andrew F . Davis" <afd@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Suman Anna <s-anna@...com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

On 12/05/2020 23:38, Tony Lindgren wrote:
> The PRM (Power and Reset Module) has registers to enable and disable
> power domains, so let's update the binding for that.
> 
> Cc: devicetree@...r.kernel.org
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
>   Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> --- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> @@ -18,12 +18,16 @@ Required properties:
>   		(base address and length)
>   
>   Optional properties:
> +- #power-domain-cells:	Should be 0 if the PRM instance is a power domain.
>   - #reset-cells:	Should be 1 if the PRM instance in question supports resets.
> +- clocks: Functional and interface clocks managed by the power domain
> +- clock-names: Names for the clocks using "fck" and "ick" naming

Whats the purpose of the clocks for PRM? It looks like you are using 
this with ABE domain on omap4/omap5, but why is this needed?

-Tero

>   
>   Example:
>   
>   prm_dsp2: prm@...0 {
>   	compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
>   	reg = <0x1b00 0x40>;
> +	#power-domain-cells = <0>;
>   	#reset-cells = <1>;
>   };
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Powered by blists - more mailing lists