linux-kernel - Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Return true in function vmw_fence_obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b30cc20-95d4-009b-6c77-f1119d396e8b@vmware.com>
Date:   Thu, 14 May 2020 10:39:35 +0200
From:   Roland Scheidegger <sroland@...are.com>
To:     Jason Yan <yanaijie@...wei.com>,
        <linux-graphics-maintainer@...are.com>, <thellstrom@...are.com>,
        <airlied@...ux.ie>, <daniel@...ll.ch>, <sumit.semwal@...aro.org>,
        <chris@...is-wilson.co.uk>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Return true in
 function vmw_fence_obj_signaled()

I've pulled that into our tree, thanks!

Roland

Am 07.05.20 um 13:07 schrieb Jason Yan:
> Fix the following coccicheck warning:
> 
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:518:9-10: WARNING: return of 0/1
> in function 'vmw_fence_obj_signaled' with return type bool
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index 178a6cd1a06f..0f8d29397157 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -515,7 +515,7 @@ bool vmw_fence_obj_signaled(struct vmw_fence_obj *fence)
>  	struct vmw_fence_manager *fman = fman_from_fence(fence);
>  
>  	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
> -		return 1;
> +		return true;
>  
>  	vmw_fences_update(fman);
>  
>