lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 May 2020 09:04:14 +0800 From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@...ux.intel.com> To: Andy Shevchenko <andriy.shevchenko@...el.com> Cc: linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, miquel.raynal@...tlin.com, richard@....at, vigneshr@...com, arnd@...db.de, brendanhiggins@...gle.com, tglx@...utronix.de, boris.brezillon@...labora.com, anders.roxell@...aro.org, masonccyang@...c.com.tw, robh+dt@...nel.org, linux-mips@...r.kernel.org, hauke.mehrtens@...el.com, qi-ming.wu@...el.com, cheol.yong.kim@...el.com Subject: Re: [PATCH v6 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Hi Andy, On 13/5/2020 11:35 pm, Andy Shevchenko wrote: > On Wed, May 13, 2020 at 06:34:05PM +0300, Andy Shevchenko wrote: >> On Wed, May 13, 2020 at 06:46:15PM +0800, Ramuthevar,Vadivel MuruganX wrote: > > ... > >>> +static int ebu_nand_remove(struct platform_device *pdev) >>> +{ >>> + struct ebu_nand_controller *ebu_host = platform_get_drvdata(pdev); >>> + >> >>> + if (ebu_host) { >> >> How it can be NULL here? >> >>> + mtd_device_unregister(nand_to_mtd(&ebu_host->chip)); >>> + nand_cleanup(&ebu_host->chip); >>> + ebu_nand_disable(&ebu_host->chip); >>> + > >>> + if (ebu_host->dma_rx || ebu_host->dma_tx) > > This is duplicate and thus redundant. Let me check and update, Thanks! Regards Vadivel > >>> + ebu_dma_cleanup(ebu_host); >>> + >>> + clk_disable_unprepare(ebu_host->clk); >>> + } >>> + >>> + return 0; >>> +} >
Powered by blists - more mailing lists