linux-kernel - Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABff4NQh8ZtHUfn4KYcXfgbZgiaRQb_5s5e7sq0_jZkp2OMg4Q@mail.gmail.com>
Date:   Thu, 14 May 2020 21:14:04 +0900
From:   Steve Lee <steves.lee.maxim@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Tzung-Bi Shih <tzungbi@...gle.com>, jack.yu@...ltek.com,
        ALSA development <alsa-devel@...a-project.org>,
        ryan.lee.maxim@...il.com, ckeepax@...nsource.cirrus.com,
        ryans.lee@...imintegrated.com, steves.lee@...imintegrated.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, nuno.sa@...log.com,
        geert@...ux-m68k.org, dmurphy@...com,
        Shuming [范書銘] <shumingf@...ltek.com>,
        Srini Kandagatla <srinivas.kandagatla@...aro.org>,
        rf@...nsource.wolfsonmicro.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

On Thu, May 14, 2020 at 7:17 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote:
> > On Wed, May 13, 2020 at 6:53 PM Mark Brown <broonie@...nel.org> wrote:
> > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:
>
> > > > Changes since V2:
> > > >       * Removed warn massage in max98390_dsm_calib_get func
> > > >         and add comment.
>
> > > The problem isn't the warning, the problem is that you have an empty
> > > operation.  You should either implement the function (eg, by caching the
> > > value written) or remove it and fix whatever problems you were running
> > > into further up the stack when it's missing.
>
> > The purpose for the mixer control is: to signal max98390 to start to
> > calibrate from userspace.
> > Thus,
> > max98390_dsm_calib_get() -> do nothing.
> > max98390_dsm_calib_put() -> call max98390_dsm_calibrate().
>
> In that case it should probably do something like read back if a
> callibration is currently running.

Thanks for feedback. I will follow this guide.