lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 May 2020 16:12:11 +0200 From: Greg KH <gregkh@...uxfoundation.org> To: Jeffrey Hugo <jhugo@...eaurora.org> Cc: arnd@...db.de, manivannan.sadhasivam@...aro.org, bjorn.andersson@...aro.org, wufan@...eaurora.org, pratanan@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH 3/8] qaic: Create char dev On Thu, May 14, 2020 at 08:07:41AM -0600, Jeffrey Hugo wrote: > /* Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. */ > > +#include <linux/cdev.h> > +#include <linux/idr.h> > +#include <linux/list.h> > +#include <linux/kref.h> > +#include <linux/mhi.h> > #include <linux/module.h> > #include <linux/msi.h> > +#include <linux/mutex.h> > #include <linux/pci.h> > #include <linux/pci_ids.h> > > @@ -13,9 +19,242 @@ > #define PCI_DEV_AIC100 0xa100 > > #define QAIC_NAME "Qualcomm Cloud AI 100" > +#define QAIC_MAX_MINORS 256 Why have a max? Why not just use a misc device so you make the logic a lot simple, no class or chardev logic to mess with at all. thanks, greg k-h
Powered by blists - more mailing lists