linux-kernel - Re: [PATCH] x86: Fix early boot crash on gcc-10, third try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87blmqr2w1.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 14 May 2020 17:45:50 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Matz <matz@...e.de>,
        Martin Liška <mliska@...e.cz>,
        Jakub Jelinek <jakub@...hat.com>
Subject: Re: [PATCH] x86: Fix early boot crash on gcc-10, third try

Borislav Petkov <bp@...en8.de> writes:

> Ok,
>
> here's the new version. Changes are:
>
> - It does mb() now (Linus).
> - I've added a call to prevent_tail_call_optimization() in init/main.c
>   because it does generate the stack canary there too. This is a
>   future-proof thing. (Arvind).
> - Dropped Reviewed-by tags.
> - Dropped compiler checking from the branch (Linus).
> - Added Cc:stable because gcc10 has released already, apparently.
>
> Testing with gcc10 passes after making sure that without it it would
> cause the tailcall optimization and fail stack check.
>
> Plan is to send it to Linus on the weekend so that it makes it into 5.7.

This fixed my boot issue, thanks!

Tested-by: Kalle Valo <kvalo@...eaurora.org>

[    0.000000] Linux version 5.7.0-rc4-wt-ath+ (gcc version 10.1.0 (GCC), GNU ld (GNU Binutils) 2.34) #11 SMP Thu May 14 17:28:35 EEST 2020

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches