lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 May 2020 02:51:44 +0000 From: Peter Chen <peter.chen@....com> To: Tang Bin <tangbin@...s.chinamobile.com> CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "stern@...land.harvard.edu" <stern@...land.harvard.edu>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Zhang Shengju <zhangshengju@...s.chinamobile.com> Subject: Re: [PATCH v2] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe() On 20-05-13 21:26:47, Tang Bin wrote: > The function ehci_mxc_drv_probe() does not perform sufficient error > checking after executing platform_get_irq(), thus fix it. > > Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards") > Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com> > Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com> > --- > Changes from v1 > - fix the subject. > --- > drivers/usb/host/ehci-mxc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > index c9f91e6c7..7f65c8604 100644 > --- a/drivers/usb/host/ehci-mxc.c > +++ b/drivers/usb/host/ehci-mxc.c > @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > + if (irq < 0) > + return irq; > > hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); > if (!hcd) > -- Reviewed-by: Peter Chen <peter.chen@....com> -- Thanks, Peter Chen
Powered by blists - more mailing lists