linux-kernel - Re: [patch V4 part 4 08/24] x86/entry: Provide IDTENTRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrWKi=+GUbAi+3OJ3CMaegz2HqQYNQKdwmRHb_xoc+YVgQ@mail.gmail.com>
Date:   Thu, 14 May 2020 09:39:49 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Brian Gerst <brgerst@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [patch V4 part 4 08/24] x86/entry: Provide IDTENTRY_IST

On Tue, May 5, 2020 at 7:16 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> Same as IDTENTRY but for exceptions which run on Interrupt STacks (IST) on
> 64bit. For 32bit this maps to IDTENTRY.
>
> There are 3 variants which will be used:
>       IDTENTRY_MCE
>       IDTENTRY_DB
>       IDTENTRY_NMI
>
> These map to IDTENTRY_IST, but only the MCE and DB variants are emitting
> ASM code as the NMI entry needs hand crafted ASM still.
>
> The function defines do not contain any idtenter/exit calls as these
> exceptions need special treatment.

Okay I guess, but in the long run I'm guessing that we'll want to
merge a bunch of this to DECLARE_IDTENTRY_NOASM and just manually emit
the special cases in entry_32/64.S.

Acked-by: Andy Lutomirski <luto@...nel.org>