linux-kernel - Re: [PATCH] IB/sa: Fix use-after-free in ib_nl_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4b66f61-d49e-fd87-87a5-7f5bfff6fd7f@web.de>
Date:   Fri, 15 May 2020 18:25:51 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Divya Indi <divya.indi@...cle.com>, linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Doug Ledford <dledford@...hat.com>,
        Gerd Rausch <gerd.rausch@...cle.com>,
        Håkon Bugge <haakon.bugge@...cle.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Kaike Wan <kaike.wan@...el.com>,
        Rama Nichanamatlu <rama.nichanamatlu@...cle.com>,
        Srinivas Eeda <srinivas.eeda@...cle.com>
Subject: Re: [PATCH] IB/sa: Fix use-after-free in ib_nl_send_msg()

> This patch fixes commit -
> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>
> Above commit adds the query to the request list before ib_nl_snd_msg.

I suggest to improve also this change description.

  The query to the request list was added before ib_nl_snd_msg()
  by the commit 3ebd2fd0d011 ("…").


> This flag Indicates …

… indicates …


> To handle the case where a response is received before we could set this
> flag, the response handler waits for the flag to be
> set before proceeding with the query.

Please reconsider the word wrapping.

  To handle the case where a response is received before we could set
  this flag, the response handler waits for the flag to be set
  before proceeding with the query.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus