linux-kernel - Re: [RFC][PATCH 5/5] objtool: Report missing support for subcommands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200515210448.jqseippuz52wx7ct@treble>
Date:   Fri, 15 May 2020 16:04:48 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Matt Helsley <mhelsley@...are.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Julien Thierry <jthierry@...hat.com>,
        Miroslav Benes <mbenes@...e.cz>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC][PATCH 5/5] objtool: Report missing support for subcommands

On Mon, May 11, 2020 at 10:35:13AM -0700, Matt Helsley wrote:
> The check and orc-related subcommands for objtool are x86-specific.
> To make this clear to anyone using the tool return a non-zero exit
> code and indicate in the help and usage output which commands are
> (and are not) available.
> 
> Signed-off-by: Matt Helsley <mhelsley@...are.com>

I think I'd rather the simplest approach of just having the weak
functions print an error and return an error code.  At least for now I
don't think we need to go through the trouble of advertising whether
certain commands are available.  Technically they are available, they
just always fail :-)

And, people don't tend to use objtool directly anyway.

BTW, several of the patches didn't apply cleanly to tip/master, so
you'll probably need to rebase for v2.  There've been a lot of objtool
changes lately.  Peter's been busy...

-- 
Josh