linux-kernel - Re: [PATCH] xhci: Fix log mistake of xhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd0ff565-2222-8bf0-c379-5e5d97975e98@linux.intel.com>
Date:   Fri, 15 May 2020 09:53:22 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     jiahao <jiahao243@...il.com>, mathias.nyman@...el.com,
        gregkh@...uxfoundation.org, jiahao@...omi.com
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Fix log mistake of xhci_start

On 15.5.2020 8.45, jiahao wrote:
> It is obvious that XCHI_MAX_HALT_USEC is usec,
>  not milliseconds; Replace 'milliseconds' with
> 'usec' of the debug message.
> 
> Signed-off-by: jiahao <jiahao@...omi.com>
> ---
>  drivers/usb/host/xhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
>  			STS_HALT, 0, XHCI_MAX_HALT_USEC);
>  	if (ret == -ETIMEDOUT)
>  		xhci_err(xhci, "Host took too long to start, "
> -				"waited %u microseconds.\n",
> +				"waited %u usec.\n",

It already says "microseconds", no need to change it

-Mathias