linux-kernel - Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 16:54:09 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     jiaxun.yang@...goat.com,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Huacai Chen <chenhc@...ote.com>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under
 CONFIG_HAVE_STD_PC_SERIAL_PORT

On 05/15/2020 04:19 PM, Jiaxun Yang wrote:
>
> 于 2020年5月15日 GMT+08:00 下午3:54:46, Tiezhu Yang <yangtiezhu@...ngson.cn> 写到:
>> On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
>>> On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
>>>> When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
>>>> the following build errors:
>>> how are you doing this ? To me it looks like this CONFIG option isn't
>>> used anymore.
>> Because I will use arch/mips/kernel/8250-platform.c in the near future,
>> so make MACH_LOONGSON64 selects HAVE_STD_PC_SERIAL_PORT, then
>> I find the build errors.
> Please never use it.
> If you are willing to add serial port then please do it
> in devicetree.
> Platform devices in wild is dangerous and it will break everything.

Hi Jiaxun,

OK, Thanks for your suggestion. I will rethink my plan.

Hi Thomas,

Because CONFIG_HAVE_STD_PC_SERIAL_PORT is not used anymore,
(1) Is it necessary to fix this possible build error?
or
(2) Should we remove this arch/mips/kernel/8250-platform.c?

Thanks,
Tiezhu Yang

>
>> Thanks,
>> Tiezhu Yang
>>
>>> Thomas.
>>>