linux-kernel - Re: [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 17:17:57 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Kees Cook <keescook@...omium.org>
CC:     <mcgrof@...nel.org>, <yzaikin@...gle.com>, <adobriyan@...il.com>,
        <mingo@...nel.org>, <peterz@...radead.org>,
        <akpm@...ux-foundation.org>, <yamada.masahiro@...ionext.com>,
        <bauerman@...ux.ibm.com>, <gregkh@...uxfoundation.org>,
        <skhan@...uxfoundation.org>, <dvyukov@...gle.com>,
        <svens@...ckframe.org>, <joel@...lfernandes.org>,
        <tglx@...utronix.de>, <Jisheng.Zhang@...aptics.com>,
        <pmladek@...e.com>, <bigeasy@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <wangle6@...wei.com>
Subject: Re: [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c

On 2020/5/15 16:09, Kees Cook wrote:
> On Fri, May 15, 2020 at 12:33:43PM +0800, Xiaoming Ni wrote:
>> +static int sixty = 60;
> 
> This should be const. (Which will require a cast during extra2
> assignment.)
> 
Sorry, I forgot to append const.
Thanks for your guidance.

Thanks
Xiaoming Ni