linux-kernel - Re: [PATCH] rtl8723bs: core: fix a coding style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200515100505.GA1619720@kroah.com>
Date:   Fri, 15 May 2020 12:05:05 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     heshuai1 <hexiaoshuaishuai@...il.com>
Cc:     vkor@...en.in, nishkadg.linux@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        heshuai1 <heshuai1@...omi.com>
Subject: Re: [PATCH] rtl8723bs: core: fix a coding style error

On Fri, May 15, 2020 at 05:40:44PM +0800, heshuai1 wrote:
> Fix this coding style error reported by checkpatch.pl:
>   ERROR: do not use assignment in if condition
>   #1120: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1120::
>   +	 if ((addr = of_get_property(np, "local-mac-address", &len)) &&
> 
> Signed-off-by: heshuai1 <heshuai1@...omi.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index ca98274..06be1d4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1117,8 +1117,8 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
>  	}
>  
>  	if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {
> -		if ((addr = of_get_property(np, "local-mac-address", &len)) &&
> -		    len == ETH_ALEN) {
> +		addr = of_get_property(np, "local-mac-address", &len);
> +		if (addr && len == ETH_ALEN) {
>  			ether_addr_copy(mac_addr, addr);
>  		} else {
>  			eth_random_addr(mac_addr);
> -- 
> 2.7.4


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot