linux-kernel - Re: [PATCH] mfd: remove max8907 wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 11:42:00 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     LKLM <linux-kernel@...r.kernel.org>,
        Gyungoh Yoo <jack.yoo@...im-ic.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] mfd: remove max8907 wake_base

On Thu, 30 Apr 2020, mjz wrote:

Please could you change your sender and SoB to your proper name and
ensure they match please.

> regmap irqchip should not use wake_base the same as mask_base.
> if use enable_irq_wake in drivers can cause mask_base write, cause
> the disabled irq to enable.

Could you please try to use correct grammar in commit messages.
Names of things should start with capital letters, as should
sentences.

> Signed-off-by: maijianzhang <maijianzhang@...winnertech.com>
> ---
>  drivers/mfd/max8907.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
> index d44baafd9d14..6346a3985088 100644
> --- a/drivers/mfd/max8907.c
> +++ b/drivers/mfd/max8907.c
> @@ -130,7 +130,6 @@ static const struct regmap_irq_chip max8907_chg_irq_chip = {
>  	.name = "max8907 chg",
>  	.status_base = MAX8907_REG_CHG_IRQ1,
>  	.mask_base = MAX8907_REG_CHG_IRQ1_MASK,
> -	.wake_base = MAX8907_REG_CHG_IRQ1_MASK,
>  	.irq_reg_stride = MAX8907_REG_CHG_IRQ2 - MAX8907_REG_CHG_IRQ1,
>  	.num_regs = 2,
>  	.irqs = max8907_chg_irqs,

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog