linux-kernel - Re: [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200514.180125.970958854699328151.davem@davemloft.net>
Date:   Thu, 14 May 2020 18:01:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     frextrite@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        kaber@...sh.net, sfr@...b.auug.org.au, cai@....pw,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        joel@...lfernandes.org, madhuparnabhowmik10@...il.com,
        paulmck@...nel.org
Subject: Re: [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning

From: Amol Grover <frextrite@...il.com>
Date: Thu, 14 May 2020 23:31:02 +0530

> ipmr_for_each_table() macro uses list_for_each_entry_rcu()
> for traversing outside of an RCU read side critical section
> but under the protection of rtnl_mutex. Hence, add the
> corresponding lockdep expression to silence the following
> false-positive warning at boot:
> 
> [    4.319347] =============================
> [    4.319349] WARNING: suspicious RCU usage
> [    4.319351] 5.5.4-stable #17 Tainted: G            E
> [    4.319352] -----------------------------
> [    4.319354] net/ipv4/ipmr.c:1757 RCU-list traversed in non-reader section!!
> 
> Fixes: f0ad0860d01e ("ipv4: ipmr: support multiple tables")
> Signed-off-by: Amol Grover <frextrite@...il.com>

Applied.